[KYUUBI #5377][FOLLOWUP] Get limit from more spark plan and regard result max rows #5963
+59
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
force-pushed
the
incremental_save
branch
3 times, most recently
from
ba264ff to
367622b
Compare
turboFei
force-pushed
the
incremental_save
branch
from
367622b to
0f734ee
Compare
ulysses-you
reviewed
Jan 12, 2024
.../kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/sql/kyuubi/SparkDatasetHelper.scala
Outdated
Show resolved
Hide resolved
turboFei
changed the title
ulysses-you
approved these changes
Jan 15, 2024
pan3793
reviewed
Jan 15, 2024
.../kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/sql/kyuubi/SparkDatasetHelper.scala
Outdated
Show resolved
Hide resolved
cfmcgrady
approved these changes
Jan 15, 2024
cxzl25
approved these changes
Jan 15, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5963 +/- ##
============================================
- Coverage 61.27% 61.04% -0.23%
Complexity 23 23
============================================
Files 622 623 +1
Lines 36882 37150 +268
Branches 5014 5035 +21
============================================
+ Hits 22599 22679 +80
- Misses 11854 12014 +160
- Partials 2429 2457 +28 ☔ View full report in Codecov by Sentry. |
|
logical plan can not cover the case likes: So, I revert to use sparkPlan. |
turboFei
changed the title
turboFei
changed the title
|
@turboFei can we use optimizedPlan ? |
turboFei
force-pushed
the
incremental_save
branch
from
c97a72e to
196845a
Compare
|
addressed. @ulysses-you |
ulysses-you
approved these changes
Jan 29, 2024
turboFei
force-pushed
the
incremental_save
branch
from
196845a to
223d510
Compare
|
thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
…ard result max rows # 🔍 Description Followup apache#5591 Support to get existing limit from more plan and regard the result max rows. ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5963 from turboFei/incremental_save. Closes apache#5377 223d510 [Fei Wang] use optimized plan ecefc2a [Fei Wang] use spark plan 57091e5 [Fei Wang] minor 2096144 [Fei Wang] for logical plan 0f734ee [Fei Wang] ut fdc1155 [Fei Wang] save f8e405a [Fei Wang] math.min Authored-by: Fei Wang <[email protected]> Signed-off-by: Fei Wang <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…ard result max rows # 🔍 Description Followup apache#5591 Support to get existing limit from more plan and regard the result max rows. ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5963 from turboFei/incremental_save. Closes apache#5377 223d510 [Fei Wang] use optimized plan ecefc2a [Fei Wang] use spark plan 57091e5 [Fei Wang] minor 2096144 [Fei Wang] for logical plan 0f734ee [Fei Wang] ut fdc1155 [Fei Wang] save f8e405a [Fei Wang] math.min Authored-by: Fei Wang <[email protected]> Signed-off-by: Fei Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Followup #5591
Support to get existing limit from more plan and regard the result max rows.
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.